[core] fix deduping rings in querying, #11357

[ansis]

fix #11357

Different rings for the same feature were being assigned different indices. This assigns the same index to all features. -js already has the correct behaviour.

cc @mb12 @ChrisLoer

[mb12]

@ansis Can you please kindly clarify the following regarding polygons and the spatial index constructed on polygon geometries?

Is there any advantage to inserting bounding box for all the internal rings of a polygon? Wouldn't it be efficient to just insert the bounding box of only the outer polygon (or if its a multipolygon just the outer ring of each polygon comprising the multipolygon)? The results of the index query have to be run against the actual polygon to rule out false positives. Adding internal rings to spatial index does not seem to have any advantage.

[ChrisLoer]

👍

@mb12 That's a good point that inner rings may not be necessary for the coarse lookup step. There might be a useful optimization there (maybe for tiles with dense building geometries?), but I think we'd track that separately (and we'd want to be careful not to introduce bugs by accidentally making assumptions about the input geometry).

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ChrisLoer]

Whoa, we just forgot about this, right @ansis? I think we should still merge this.

[kkaefer]

bump

[stale]

This pull request has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

[ChrisLoer]

Back off stale-bot, we just need to merge this!