Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

UI thread checking #12000

Merged
merged 2 commits into from
May 25, 2018
Merged

UI thread checking #12000

merged 2 commits into from
May 25, 2018

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented May 24, 2018

Closes #9896

@tobrun tobrun added the Android Mapbox Maps SDK for Android label May 24, 2018
@tobrun tobrun added this to the android-v6.2.0 milestone May 24, 2018
@tobrun tobrun self-assigned this May 24, 2018
@tobrun tobrun requested a review from LukasPaczos May 24, 2018 11:29
@tobrun tobrun force-pushed the tvn-add-thread-checking branch from 9c7ada5 to fd67d90 Compare May 24, 2018 11:30
LukasPaczos
LukasPaczos suggested changes May 24, 2018
View reviewed changes
Copy link
Contributor

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are missing checks in Light.java and MapSnapshotter.java.

@tobrun tobrun force-pushed the tvn-add-thread-checking branch from fd67d90 to 59a2394 Compare May 24, 2018 15:35
@tobrun
Copy link
Member Author

tobrun commented May 24, 2018

Nice catch @LukasPaczos, added with 59a2394

@tobrun tobrun force-pushed the tvn-add-thread-checking branch from e706d3d to d9de6d0 Compare May 25, 2018 08:34
@tobrun tobrun force-pushed the tvn-add-thread-checking branch from d9de6d0 to d90289e Compare May 25, 2018 09:25
@tobrun tobrun merged commit 7aaf492 into master May 25, 2018
@tobrun tobrun deleted the tvn-add-thread-checking branch May 25, 2018 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LukasPaczos LukasPaczos LukasPaczos approved these changes

Assignees

@tobrun tobrun

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
android-v6.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tobrun @LukasPaczos