This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Optional map snapshotter camera position #12029
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking into render differences from android render tests, I was noticing the following behavior:
With using the following style.json:
Was able to track down that our camera definition in the style.json was overwritten by the default camera:
This PR fixes that behavior by using
optional<mbgl::CameraOptions>
instead ofCameraOptions&
.