Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Fix match stop conversion #12128

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Fix match stop conversion #12128

merged 1 commit into from
Jun 12, 2018

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jun 11, 2018

Closes #12101, this PR needs a CP to release-chai.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jun 11, 2018
@tobrun tobrun added this to the android-v6.2.0 milestone Jun 11, 2018
@tobrun tobrun self-assigned this Jun 11, 2018
@tobrun tobrun requested a review from LukasPaczos June 11, 2018 22:31
@tobrun
Copy link
Member Author

tobrun commented Jun 12, 2018

Capturing from chat with @LukasPaczos, instead of removing the exception, let's fix this up in the expression conversion code. Atm we will wrap expressions with literal when used with match. By hooking into Stop.toExpressionArray(stops), we can eliminate this.

@tobrun tobrun changed the title Remove exception throw for expression literal Fix match stop conversion Jun 12, 2018
Copy link
Member

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants