Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Android licenses make target #12139

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Conversation

LukasPaczos
Copy link
Contributor

Closes #11854.

This PR adds android-license make target which generates platform/android/LICENSE.md based on all dependencies' POM files. This file is then referenced from the top level LICENSE.md.

@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Jun 13, 2018
@LukasPaczos LukasPaczos requested review from zugaldia and tobrun June 13, 2018 16:31
Copy link
Member

@zugaldia zugaldia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comment to address, it otherwise looks spot on. Great find on that Gradle plugin!

@@ -0,0 +1,117 @@
## Additional Mapbox GL licensesMapbox GL uses portions of the Android Arch-Common.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukasPaczos Missing new line between licensesMapbox.

Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LukasPaczos LukasPaczos force-pushed the 11854-update-android-licenses branch from 421ab4c to ad6a1f4 Compare June 14, 2018 09:32
@LukasPaczos LukasPaczos merged commit 2096908 into master Jun 14, 2018
@LukasPaczos LukasPaczos deleted the 11854-update-android-licenses branch June 14, 2018 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants