[core] Tweak conversions to reduce binary size #12511

jfirebaugh · 2018-07-30T22:34:43Z

return {} → return nullopt
error = { "..." } → error.message = "..."

mollymerp

Nice 📉 – trusting the tests here bc I'm not familiar with how clang handles the difference of value initialization vs nullopt or the changes to modifying the errors but the size reductions look good!

* return {} → return nullopt * error = { "..." } → error.message = "..."

jfirebaugh requested a review from mollymerp July 30, 2018 22:34

mollymerp approved these changes Jul 30, 2018

View reviewed changes

[core] Tweak conversions to reduce binary size

4807473

* return {} → return nullopt * error = { "..." } → error.message = "..."

jfirebaugh force-pushed the slim-conversion branch from 54c437a to 4807473 Compare July 30, 2018 23:56

jfirebaugh merged commit 9a1bb1a into master Jul 31, 2018

jfirebaugh deleted the slim-conversion branch July 31, 2018 00:17

kkaefer added refactor Core The cross-platform C++ core, aka mbgl labels Jul 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core] Tweak conversions to reduce binary size #12511

[core] Tweak conversions to reduce binary size #12511

jfirebaugh commented Jul 30, 2018

mollymerp left a comment

[core] Tweak conversions to reduce binary size #12511

[core] Tweak conversions to reduce binary size #12511

Conversation

jfirebaugh commented Jul 30, 2018

mollymerp left a comment

Choose a reason for hiding this comment