Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Refs #1256 - Fix some erronenous tracking mode resets #1257

Closed
wants to merge 1 commit into from
Closed

Refs #1256 - Fix some erronenous tracking mode resets #1257

wants to merge 1 commit into from

Conversation

friedbunny
Copy link
Contributor

  • Adds private preservingTracking: version of setCenterCoordinate:zoomLevel:animated:
  • Changes zoomToSouthWestCoordinate:northEastCoordinate:animated: to above preservingTracking:, fixes an untended tracking mode reset
  • Removes tracking mode reset from resetNorthAnimated:
    • handleCompassTapGesture: was intending to simply bump down to MGLUserTrackingModeFollow if it was following with heading, but it was getting clobbered by resetNorthAnimated:.

Only fixes half of #1256.

@friedbunny friedbunny changed the title #1256 - Fix some erronenous tracking mode resets Refs #1256 - Fix some erronenous tracking mode resets Apr 11, 2015
@friedbunny
Copy link
Contributor Author

May be better to move the tracking mode check from handleCompassTapGesture to resetNorthAnimated, though there are already plenty of ways to reset the tracking mode if a developer wanted to.

@friedbunny friedbunny added bug iOS Mapbox Maps SDK for iOS labels May 2, 2015
@1ec5 1ec5 mentioned this pull request Jun 24, 2015
9 tasks
@jfirebaugh
Copy link
Contributor

@1ec5 / @friedbunny Can you coordinate what remains to be done here and get this merged?

@1ec5
Copy link
Contributor

1ec5 commented Jun 30, 2015

@friedbunny, it looks like #1783 took care of the -zoomToSouthWestCoordinate:northEastCoordinate:animated: case. Do you think we still need a way to prevent resetting the user tracking mode generally? If so, that version of the method should be exposed publicly. Otherwise, this PR can be closed.

@friedbunny
Copy link
Contributor Author

The resetNorthAnimated: tracking mode reset still needs to be removed, but I've broken that out into a new pull request (#1809). Closing here.

@friedbunny friedbunny closed this Jul 1, 2015
@friedbunny friedbunny deleted the 1256-tracking-modes branch July 1, 2015 03:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants