This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Canonicalize another exception name #12640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
force-pushed
the
1ec5-exception-standardization-12583
branch
from
d2a016e to
96ffe2d
Compare
1ec5
force-pushed
the
1ec5-exception-standardization-12583
branch
from
96ffe2d to
890b09d
Compare
friedbunny
approved these changes
Aug 15, 2018
platform/ios/CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT | |||
| * Fixed inconsistencies in exception naming. ([#12583](https://github.com/mapbox/mapbox-gl-native/issues/12583)) | |||
| * Don't default-show text/icons that depend on the placement of a paired icon/text [#12483](https://github.com/mapbox/mapbox-gl-native/issues/12483) | |||
| * Fix the behavior of `-[MGLMapView visibleFeaturesAtPoint:]` near tile boundaries at high zoom. ([#12472](https://github.com/mapbox/mapbox-gl-native/issues/12472)) | |||
| * Fixed inconsistencies in exception naming. ([#12583](https://github.com/mapbox/mapbox-gl-native/issues/12583)) | |||
There was a problem hiding this comment.
I meant to make that change to the macOS changelog, not the iOS one. I’ve already fixed it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced one more exception name string with a formal symbol as a followup to #12583.
/cc @friedbunny