This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Refactor Android conversion code #12678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
force-pushed
the
android-conversion-cpp
branch
from
3b93aec
to
165beb1
Compare
ivovandongen
approved these changes
Aug 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on upgrading to the latest version of jni.hpp and found that it would be easier if I did some preparatory cleanup work first.
operator()s to .cpp files. This is something that we did for core conversion back in Runtime polymorphic conversion #10075, but didn't bring to Android until now.