This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[Core] Ensure queryRenderedFeatures accounts for icons with *-offset … #13105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhamley
added
GL JS parity
ryanhamley
force-pushed
the
fix-rotated-icon-query
branch
from
0d255ac
to
d5dfa1b
Compare
|
looks like you need to update the tests in cross_tile_symbol_index.test.cpp – you can run the tests locally by using the |
ChrisLoer
reviewed
Oct 17, 2018
| const Point<float> bl = util::rotate(Point<float>(x1, y2), rotateRadians); | ||
| const Point<float> br = util::rotate(Point<float>(x2, y2), rotateRadians); | ||
|
|
||
| const float xMin = std::min({tl.x, tr.x, bl.x, br.x}); |
There was a problem hiding this comment.
Could you bring over the comments from GL JS here or something similar? I think the "we have to represent on-axis geometry, so take the envelope of the rotated geometry" step is fairly non-obvious to someone casually browsing the code.
There was a problem hiding this comment.
I just copied over your comments
|
Overall this looks great to me! 🚀 |
|
@mollymerp Thanks for pointing that out! I was having trouble figuring out why the tests broke once I rebased against master. |
ryanhamley
force-pushed
the
fix-rotated-icon-query
branch
from
d5dfa1b
to
10e9fd2
Compare
ChrisLoer
approved these changes
Oct 18, 2018
friedbunny
removed
needs changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12909 and implements #11872
This is a pretty straightforward port of mapbox/mapbox-gl-js#6631 which allows icons with
icon-rotateandicon-offsetto show up inqueryRenderedFeaturesresults as expected.