This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Do not consider X axis when constraining scale #13463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoabinader
added
GL JS parity
brunoabinader
force-pushed
the
constrain-scale-no-y-axis
branch
from
a1b083f
to
7cc33d7
Compare
mourner
reviewed
Nov 28, 2018
|
Noting that I ended up implementing support for fill-extrusion-vertical-gradient (mapbox/mapbox-gl-js#6841), 99% of the code was auto-generated, I only needed to add a single line manually here for it to work. Fixes #13462. |
brunoabinader
force-pushed
the
constrain-scale-no-y-axis
branch
from
c8887b3
to
c6e056d
Compare
brunoabinader
force-pushed
the
constrain-scale-no-y-axis
branch
from
b6bfde7
to
e821980
Compare
brunoabinader
force-pushed
the
constrain-scale-no-y-axis
branch
from
e821980
to
995877d
Compare
1ec5
reviewed
Nov 28, 2018
brunoabinader
force-pushed
the
constrain-scale-no-y-axis
branch
2 times, most recently
from
aba8c9a
to
cc95a75
Compare
mourner
approved these changes
Nov 29, 2018
brunoabinader
force-pushed
the
constrain-scale-no-y-axis
branch
from
cc95a75
to
279f684
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #12611, back then I did not realize that GL JS's behavior was to not consider X axis when constraining scale. This PR fixes this edge case, and uses the newly added
basic-v9/z0-narrow-yrender test to verify parity with GL JS.This fix uncovered an issue with heatmaps, where features outside the tile extent where considered in still rendering mode (@mourner you were right in #12611 (comment) - it was indeed two points being rendered, one inside the tile extent, and the other outside).