This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios, macos] Add enablePlacementTransitions to MGLStyle. #13565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabian-guerra
added
GL JS parity
julianrex
reviewed
Dec 13, 2018
| self.style.transition = transitionTest; | ||
|
|
||
| XCTAssert(self.style.transition.delay == transitionTest.delay); | ||
| XCTAssert(self.style.transition.duration == transitionTest.duration); |
There was a problem hiding this comment.
Does this also need to test enablePlacementTransitions?
There was a problem hiding this comment.
Since I split the functionality in transition and enablePlacementTransitions I'm testing the latter in it's own test method.
There was a problem hiding this comment.
Ah yes, I'm thinking of a previous discussion I saw on the previous PR!
julianrex
approved these changes
Dec 13, 2018
fabian-guerra
force-pushed
the
fabian-placement-transition-13408
branch
from
e4bdb8e to
fbba090
Compare
1ec5
reviewed
Dec 18, 2018
|
|
||
| The default value of this property is `YES`. | ||
| */ | ||
| @property (nonatomic, assign) BOOL enablePlacementTransitions; |
There was a problem hiding this comment.
This property has an imperative name, which makes it look like an action method in Objective-C:
// Initial state: placement transitions are disabled.
[style enablePlacementTransitions];
// Expected behavior: placement transitions are enabled.
// Actual behavior: nothing changed; return value discarded.This property should be renamed to placementTransitionsEnabled or preferably performsPlacementTransitions. (enablesPlacementTransitions is problematic because it’s the developer, not the style, that enables them.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13408 and #13035