This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Split layer type specific code in mbgl::Programs #13577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
force-pushed
the
mikhail_layer_programs
branch
from
a292949 to
d51b9c2
Compare
pozdnyakov
force-pushed
the
mikhail_layer_programs
branch
from
e976ba6 to
25ea831
Compare
kkaefer
reviewed
Jan 7, 2019
src/mbgl/programs/programs.cpp
Outdated
| property = std::make_unique<ProgramsType>(context, programParameters); \ | ||
| } \ | ||
| return static_cast<ProgramsType&>(*property); \ | ||
| } |
There was a problem hiding this comment.
We try to use as little macros as possible. While the macro is a bit shorter, writing out all functions verbatim doesn't look like it'd be too much code either.
There was a problem hiding this comment.
OK, will remove it
| std::unique_ptr<LayerTypePrograms> fillPrograms; | ||
| std::unique_ptr<LayerTypePrograms> fillExtrusionPrograms; | ||
| std::unique_ptr<LayerTypePrograms> linePrograms; | ||
| std::unique_ptr<LayerTypePrograms> symbolPrograms; |
There was a problem hiding this comment.
Why do we need an abstract base class here?
There was a problem hiding this comment.
unique_ptr requires a destructor defined, so pointers to the concrete classes would prevent from LTO removing them from the binaries.
pozdnyakov
force-pushed
the
mikhail_layer_programs
branch
from
25ea831 to
2743ef0
Compare
|
@kkaefer thanks for your comments! addressed in the latest patch |
|
@alexshalamov @tmpsantos Could you also take a look? |
Progams code for a certain layer type is encapsulted within a dedicated `<layer type>Programs` class, inherited from the generic base `LayerTypePrograms` class. `mbgl::Programs::get<layer type>Programs()` lazily initializes the layer type-specific programs code using pointer to the base class, which allows LTO to remove this code from binaries (if the corresponding `get<layer type>Programs()` method can never be invoked).
pozdnyakov
force-pushed
the
mikhail_layer_programs
branch
from
2743ef0 to
33a98b9
Compare
alexshalamov
approved these changes
Jan 11, 2019
kkaefer
approved these changes
Jan 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Programs code for a certain layer type is encapsulated within
a dedicated
<layer type>Programsclass, inherited fromthe generic base
LayerTypeProgramsclass.mbgl::Programs::get<layer type>Programs()lazily initializes thelayer type-specific programs code using pointer to the base class,
which allows LTO to remove this code from binaries (if the corresponding
get<layer type>Programs()method can never be invoked).Tagging #13276