This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios, macos] Fix number conversions when expressions cast to large numbers. #13580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabian-guerra
added
iOS
julianrex
reviewed
Dec 14, 2018
platform/darwin/src/MGLConversion.h
Outdated
| @@ -85,7 +85,7 @@ class ConversionTraits<Holder> { | |||
| static optional<float> toNumber(const Holder& holder) { | |||
| const id value = holder.value; | |||
| if (_isNumber(value)) { | |||
| return ((NSNumber *)value).floatValue; | |||
| return ((NSNumber *)value).doubleValue; | |||
There was a problem hiding this comment.
The return type is an optional<float> here. I think we should check that value is in the range of a float. Do we have an existing method for that?
fabian-guerra
force-pushed
the
fabian-conversion-13527
branch
from
5984fde to
af48aab
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13527