This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[Android] Added Style object parameter mention to LocationComponent methods #13588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests are failing because of my idiotically-named branch name which has ` in it 🤦♂️ |
|
Tried to rename the branch locally and remotely via guides such as https://multiplestates.wordpress.com/2015/02/05/rename-a-local-and-remote-branch-in-git/. Doesn't seem to work for some reason. In the interest of time, going to close this pr and re-open a new one. |
langsmith
deleted the
ls-adding-style-param-javadocs-to-`LocationComponent`-class
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds missing mentions of the
Styleparameter object to the javadocs for theLocationComponent'sactivateLocationComponent()methods. These docs will help guide folks who are wondering what this newStyleobject is about.@LukasPaczos & @tobrun , if you want to tweak the explanation of the
Styleparameter, go ahead and just push your changes. I used the same sentence everywhere, so you can use Android Studio's find+replaceAll feature to the same sentence all in one go.