This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Implement android test runner for core unit tests #13617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of the tests are passing, except:
|
alexshalamov
force-pushed
the
alexshalamov_fix_core_android_unittests
branch
from
1888807
to
4104767
Compare
tobrun
approved these changes
Dec 20, 2018
There was a problem hiding this comment.
This is amazing and long overdue! thank you for picking this up @alexshalamov.
Once this is merged we should try setting up a CI bot with this.
alexshalamov
force-pushed
the
alexshalamov_fix_core_android_unittests
branch
from
4104767
to
d8cc12b
Compare
kkaefer
approved these changes
Jan 2, 2019
alexshalamov
force-pushed
the
alexshalamov_fix_core_android_unittests
branch
from
d8cc12b
to
d909e19
Compare
|
@kkaefer There are few failing cases due to small pixel mismatch differences in rendering, I couldn't figure out how to align all platforms to produce stable results. I've added d909e19 to filter-out some of the failures. Is this fine or maybe you would have better idea how to tackle it? |
alexshalamov
force-pushed
the
alexshalamov_fix_core_android_unittests
branch
2 times, most recently
from
3117565
to
5bcea50
Compare
alexshalamov
force-pushed
the
alexshalamov_fix_core_android_unittests
branch
from
5bcea50
to
2e00a87
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private APIs from android_runtime.so are no longer accessible, thus, core unit tests are segfaulting on android platform.
This PR introduces simple unit test runner and VM initialization code that can be reused for benchmark tests.