Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

NativeMap abstraction #13681

Merged
merged 2 commits into from
Jan 15, 2019
Merged

NativeMap abstraction #13681

merged 2 commits into from
Jan 15, 2019

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jan 7, 2019

This PR adds a NativeMap abstraction on top of NativeMapView:

Changes include:

  • all classes depending on NativeMapView are depending on NativeMap instead
  • removed static code block remover for unit test, we test against a mocked interface instead
  • optimised the interface definition by changing method signatures and in case of transition options use the actual object vs 2 long values.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jan 7, 2019
@tobrun tobrun added this to the android-v7.1.0 milestone Jan 7, 2019
@tobrun tobrun self-assigned this Jan 7, 2019
@tobrun tobrun requested a review from LukasPaczos January 7, 2019 16:18
@tobrun tobrun force-pushed the tvn-nativemapview-abstraction branch 2 times, most recently from a583ef0 to 02b98f1 Compare January 7, 2019 16:42
@tobrun tobrun force-pushed the tvn-nativemapview-abstraction branch 4 times, most recently from fdb370e to c3cf584 Compare January 10, 2019 17:45
@tobrun tobrun force-pushed the tvn-nativemapview-abstraction branch from c3cf584 to dcb3d59 Compare January 11, 2019 18:54
@tobrun tobrun force-pushed the tvn-nativemapview-abstraction branch from dcb3d59 to 09f8376 Compare January 15, 2019 11:52
@tobrun tobrun merged commit e6e07a6 into master Jan 15, 2019
@tobrun tobrun deleted the tvn-nativemapview-abstraction branch January 15, 2019 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LukasPaczos LukasPaczos LukasPaczos approved these changes

Assignees

@tobrun tobrun

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
android-v7.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tobrun @LukasPaczos