This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fixes a bug where the animated parameter of -[MGLMapView selectAnnotation:animated:] was ignored. #13689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 8, 2019 12:21
Fixed bug where animateSelection was always YES in selectAnnotation:animated:
1ec5
approved these changes
Jan 8, 2019
| CGRect positioningRect = [self positioningRectForAnnotation:annotation defaultCalloutPoint:CGPointZero]; | ||
| [self selectAnnotation:annotation moveOnscreen:animated animateSelection:YES calloutPositioningRect:positioningRect]; | ||
| [self selectAnnotation:annotation moveIntoView:moveIntoView animateSelection:animateSelection calloutPositioningRect:positioningRect]; |
There was a problem hiding this comment.
Should deselection in response to another annotation being selected also honor the animated flag, for consistency?
mapbox-gl-native/platform/ios/src/MGLMapView.mm
Line 4596 in e2e38dd
mapbox-gl-native/platform/ios/src/MGLMapView.mm
Line 4882 in e2e38dd
There was a problem hiding this comment.
Thanks for the quick review!
I had the very same question 🙂 I can imagine situations where different applications would want different results. I think leaving as is makes the most sense at present, and we can tackle in a subsequent PR if necessary.
friedbunny
reviewed
Jan 9, 2019
added 2 commits
January 9, 2019 11:49
friedbunny
approved these changes
Jan 9, 2019
Merged
4 tasks
This was referenced Jun 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13055
Also:
moveOnscreen->moveIntoView)-[MGLMapView selectAnnotation:moveIntoView:animateSelection:]to the public header, but marked as undocumented.