Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Remove deprecated javacompile #13777

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Remove deprecated javacompile #13777

merged 1 commit into from
Jan 23, 2019

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jan 23, 2019

Starting with Android Studio 3.3.0, we will receive a warning when we perform a gradle sync:

WARNING: API 'variant.getJavaCompile()' is obsolete and has been replaced with 'variant.getJavaCompileProvider()'. It will be removed at the end of 2019. For more information, see https://d.android.com/r/tools/task-configuration-avoidance. To determine what is calling variant.getJavaCompile(), use -Pandroid.debug.obsoleteApi=true on the command line to display a stack trace.

Capturing a solution from here. We need to replace the following:

source = variant.getJavaCompiler().source	

with

source = variant.sourceSets.collect { it.java.sourceFiles }.inject { m, i -> m + i }

cc @mapbox/android, this fix needs to be applied to other projects using the same javadoc configuration

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jan 23, 2019
@tobrun tobrun self-assigned this Jan 23, 2019
@tobrun tobrun requested a review from LukasPaczos January 23, 2019 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants