This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios, macos] Add Czech and Hungarian translations. #13782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabian-guerra
added
iOS
friedbunny
suggested changes
Jan 23, 2019
There was a problem hiding this comment.
The files where GitHub says “Binary file not shown” are in UTF-16 encoding, but we want these to be UTF-8 (as they’re easier to work with, diffable, and follows Apple’s recommendation).
You can check file encoding like so:
$ file -I platform/macos/sdk/cs.lproj/Localizable.strings
platform/macos/sdk/cs.lproj/Localizable.strings: text/plain; charset=utf-16le
And it can be converted using Xcode’s file inspector or via iconv:
iconv -f UTF-16LE -t UTF-8 <filename> -o <new-filename>
fabian-guerra
force-pushed
the
fabian-update-translations
branch
from
dfa431f to
1ee878b
Compare
friedbunny
approved these changes
Jan 23, 2019
fabian-guerra
added a commit
that referenced
this pull request
Jan 23, 2019
Added Czech translations.
fabian-guerra
added a commit
that referenced
this pull request
Jan 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Czech and Hungarian translations.