Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Revert Android libs vendorization in buildscript, keep submodule pins #13806

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

LukasPaczos
Copy link
Member

This PR reverts changes from #13712, #13738, #13765 and uses binaries for local builds but still keeps submodule pins to the release tags of upstream repositories that were used to compile those consumed binaries.

As a safety measure, this PR also adds a script that verifies whether the checked out submodule's commit hash is equal to the release tag's commit hash. The release tag that should be used is determined based on the binary dependency version and the upstream repository's tag naming convention.

@LukasPaczos LukasPaczos added build Android Mapbox Maps SDK for Android labels Jan 28, 2019
@LukasPaczos LukasPaczos added this to the android-v7.1.0 milestone Jan 28, 2019
@LukasPaczos LukasPaczos force-pushed the lp-revert-vendor-keep-submodule branch from ce5bcab to fb90ce5 Compare January 28, 2019 12:30
@LukasPaczos LukasPaczos force-pushed the lp-revert-vendor-keep-submodule branch from fb90ce5 to b1e2e55 Compare January 29, 2019 09:00
@LukasPaczos LukasPaczos merged commit e598146 into master Jan 29, 2019
@LukasPaczos LukasPaczos deleted the lp-revert-vendor-keep-submodule branch January 29, 2019 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants