This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Revert Android libs vendorization in buildscript, keep submodule pins #13806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
force-pushed
the
lp-revert-vendor-keep-submodule
branch
from
ce5bcab
to
fb90ce5
Compare
tobrun
approved these changes
Jan 28, 2019
LukasPaczos
force-pushed
the
lp-revert-vendor-keep-submodule
branch
from
fb90ce5
to
b1e2e55
Compare
This was referenced Jan 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts changes from #13712, #13738, #13765 and uses binaries for local builds but still keeps submodule pins to the release tags of upstream repositories that were used to compile those consumed binaries.
As a safety measure, this PR also adds a script that verifies whether the checked out submodule's commit hash is equal to the release tag's commit hash. The release tag that should be used is determined based on the binary dependency version and the upstream repository's tag naming convention.