Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Expose symbol placement transition duration option #13868

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Expose symbol placement transition duration option #13868

merged 1 commit into from
Feb 4, 2019

Conversation

LukasPaczos
Copy link
Contributor

Closes #13402.

@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Feb 4, 2019
@LukasPaczos LukasPaczos added this to the android-v7.2.0 milestone Feb 4, 2019
@LukasPaczos LukasPaczos requested a review from tobrun February 4, 2019 12:11
@LukasPaczos LukasPaczos force-pushed the lp-13402-disable-placement-transition branch from 12eac00 to ec0c61a Compare February 4, 2019 12:15
tobrun
tobrun approved these changes Feb 4, 2019
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, two minor remarks below

...id/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/style/layers/TransitionOptions.java Show resolved Hide resolved
platform/android/src/native_map_view.cpp Outdated Show resolved Hide resolved
platform/android/src/style/conversion/transition_options.cpp Outdated Show resolved Hide resolved
@LukasPaczos LukasPaczos force-pushed the lp-13402-disable-placement-transition branch from ec0c61a to cc34eae Compare February 4, 2019 12:26
@LukasPaczos LukasPaczos modified the milestones: android-v7.2.0, release-k Feb 4, 2019
@LukasPaczos LukasPaczos merged commit 8ad13cd into master Feb 4, 2019
@LukasPaczos LukasPaczos deleted the lp-13402-disable-placement-transition branch February 4, 2019 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun tobrun approved these changes

Assignees
No one assigned
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
release-kombucha
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasPaczos @tobrun