This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Cast round json element properties to int64_t instead of the uint64_t #13882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
force-pushed
the
lp-13881-negative-conversion
branch
from
9446c82 to
8cb99d4
Compare
tobrun
reviewed
Feb 7, 2019
| @@ -166,7 +166,7 @@ RenderGeoJSONSource::queryFeatureExtensions(const Feature& feature, | |||
| return {}; | |||
| } | |||
|
|
|||
| const auto clusterID = getProperty<uint64_t>(feature.properties, "cluster_id"); | |||
| const auto clusterID = getProperty<int64_t>(feature.properties, "cluster_id"); | |||
There was a problem hiding this comment.
cluster_id is a uint64_t as created by https://github.com/mapbox/supercluster.hpp/blob/master/include/supercluster.hpp#L46 and is also referenced like this in our testing https://github.com/mapbox/mapbox-gl-native/blob/master/test/api/query.test.cpp#L196.
tobrun
added a commit
that referenced
this pull request
Feb 7, 2019
tobrun
added a commit
that referenced
this pull request
Feb 7, 2019
tobrun
added a commit
that referenced
this pull request
Feb 7, 2019
|
Closing in favor of #13888. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13881.
I was only able to come up with an Android regression test of the exact issue from #13881. I still don't exactly understand the particular rendering problem, so I'd love some more clarity if anyone has ideas of what is going wrong here.