Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Make PingFang as the default local font family #13988

Merged
merged 2 commits into from
Feb 27, 2019
Merged

[ios] Make PingFang as the default local font family #13988

merged 2 commits into from
Feb 27, 2019

Conversation

lloydsheng
Copy link
Contributor

Without set localIdeographicFontFamily would slowdown maps containing CJK fonts. We should switch "localIdeographicFontFamily" default to "on".

@lloydsheng lloydsheng requested a review from 1ec5 as a code owner February 26, 2019 05:28
@lloydsheng lloydsheng requested a review from a team February 26, 2019 05:28
julianrex
julianrex approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@julianrex julianrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - would you mind adding a change log entry too please.

@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS localization Human language support and internationalization needs changelog Indicates PR needs a changelog entry prior to merging. labels Feb 26, 2019
@friedbunny friedbunny added this to the release-l milestone Feb 26, 2019
@lloydsheng lloydsheng merged commit 0a41bb1 into master Feb 27, 2019
@friedbunny
Copy link
Contributor

friedbunny commented Feb 27, 2019 •
edited
Loading

@lloydsheng For changes targeting the next release, please go ahead and (re)create the master section at the top of the changelog, then add the entry there. 🙇

(I did this myself in #14005 as part of the release prep.)

@friedbunny friedbunny removed the needs changelog Indicates PR needs a changelog entry prior to merging. label Feb 27, 2019
@friedbunny friedbunny deleted the lloyd-local-font branch February 27, 2019 19:56
@ChrisLoer
Copy link
Contributor

Hooray! 🎉

@honjo2 honjo2 mentioned this pull request Apr 22, 2019
Closed
@1ec5 1ec5 added the macOS Mapbox Maps SDK for macOS label May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@julianrex julianrex julianrex approved these changes

@1ec5 1ec5 Awaiting requested review from 1ec5

Assignees

@lloydsheng lloydsheng

Labels
iOS Mapbox Maps SDK for iOS localization Human language support and internationalization macOS Mapbox Maps SDK for macOS
Projects
None yet
Milestone
release-liquid
Development

Successfully merging this pull request may close these issues.
5 participants
@lloydsheng @friedbunny @ChrisLoer @julianrex @1ec5