This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13967
This PR fixes the issue of not being able to restore a backstacked map fragment. The source of the issue stems from clearing out the OnMapReadyCallback as part of OnDestroyView, this is not correct and should only happen as part of OnDestroy. OnDestroyView can be called multiple times in a fragment life time, removing the callback makes reused fragment unusable as the callback isn't fired anymore.
Looked into adding a regression test but we need androidX for that, follow up ticket in https://github.com/mapbox/mapbox-gl-native/issues/14034.
For now I'm punting on the manual test added.