Graphics refactor #4 #14126

kkaefer · 2019-03-15T11:11:20Z

…from program.hpp

…::UniformValues

kkaefer · 2019-03-15T12:08:18Z

Size diff failed for some reason, so here it is:

src/mbgl/gl/program.hpp

kkaefer added 17 commits March 15, 2019 10:16

[core] split VertexType from Vertex

20c7477

[core] mark PaintPropertyBinder subclasses as final

2ca42df

[core] move AttributeBinding to gfx namespace

a24dd07

[core] pull out AttributeBindings tuple

982e76f

[core] move attributeBinding function to gfx namespace

db813c1

[core] pull attribute binding related code into gfx namespace

f3fca65

[core] move VertexArray behind new gfx::DrawScope facade

7c291df

[core] UniformValues -> LayoutUniformValues, and remove gl::Uniforms …

e8c466e

…from program.hpp

[core] move BinaryProgram to gl namespace

5f3b1cb

[core] integrate gfx::Attributes and gfx::Attributes<>::Bindings

ed98f18

[core] mirror gfx::AttributeBindings for gfx::TextureBindings and gfx…

588556a

…::UniformValues

[core] gl::Attributes -> gl::AttributeLocations

caf8728

[core] change gl::Uniform -> gl::UniformState

d3904c7

[core] remove DrawMode template argument from gl::Program::draw()

fc77044

[core] introduce abstract gfx::Program base type

4c23608

[core] let the program know about its type name

7a6d9f5

[core] make Program interface backend-agnostic

2d799cc

kkaefer requested review from pozdnyakov and alexshalamov March 15, 2019 11:11

alexshalamov approved these changes Mar 15, 2019

View reviewed changes

src/mbgl/gl/program.hpp Show resolved Hide resolved

kkaefer merged commit c8cfdb1 into master Mar 15, 2019

kkaefer deleted the gfx-refactor-4 branch March 15, 2019 19:31

chloekraw added Core The cross-platform C++ core, aka mbgl refactor labels Jul 11, 2019

Provide feedback