[ios] Fix issue wrong position of attribution dialog after rotation

[lloydsheng]

The PR fixed #12897

[julianrex]

@lloydsheng thanks for this, can you please look at #13530 and see how that compares. That uses PR uses UIPopoverPresentationControllerDelegate methods to reposition.

[lloydsheng]

@julianrex The PR considered not only orientation changing. but also the attribution position changing and proper arrow direction for the popoverPresentationController.

[julianrex]

Looking at the docs for -popoverPresentationController:willRepositionPopoverToRect:inView:

The popover presentation controller calls this method in response to interface changes that require a new size for the popover. For example, UIKit calls this method when the popover must be resized to make room for the keyboard. You can use this method to obtain the new size of the popover and optionally to make changes to the proposed view and rectangle.

I'm wondering if there are similar cases where the popover will need to be moved to accommodate a system view that we're not considering. Can you think of any? We may want to use this delegate method in addition to repositioning the popover when attribution location changes.

Thoughts?

[lloydsheng]

@julianrex Here are all cases I can find which the alertview's position needs to be updated:

1. When the keyboard show
   • Trigger -popoverPresentationController:willRepositionPopoverToRect:inView:
2. When the interface orientation changes
   • Trigger -popoverPresentationController:willRepositionPopoverToRect:inView:
   • Trigger -layoutSubviews
3. When the mapview size changes
   • Trigger -layoutSubviews
4. When the position of the attribution button changes
   • Trigger -layoutSubviews

As you can see the only case I found which won't trigger layoutSubviews of the mapbview is the case #1. But the default behavior of UIKit handles it well as the docs said:

If you do not implement this method in your delegate, UIKit resizes the popover to the specified rectangle and moves it (as needed) to the specified view.

That's why I choose the current implementation.

[julianrex]

Thanks for double checking!

[julianrex]

Please can you add an entry to the change log.