Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Disable leak canary during instrumentation tests #14296

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

LukasPaczos
Copy link
Member

Closes #14237.

The common factor in the #14237 was leak canary freezing the app to collect the data, which caused the test to extend the "wait-for-idle" timeout and assert, even though the map was blank.

I wasn't able to reproduce the issue locally, so we can reopen #14237 if this PR doesn't fix it. In any case, we should disable leak canary during instrumentation tests anyway.

@LukasPaczos LukasPaczos added Android Mapbox Maps SDK for Android tests labels Apr 2, 2019
@LukasPaczos LukasPaczos requested a review from tobrun April 2, 2019 14:23
@LukasPaczos LukasPaczos force-pushed the lp-disable-leak-canary-instrumentation branch from 4958768 to f0f6919 Compare April 2, 2019 14:36
@LukasPaczos LukasPaczos force-pushed the lp-disable-leak-canary-instrumentation branch from f0f6919 to fd24f9b Compare April 2, 2019 15:25
@LukasPaczos
Copy link
Member Author

Turns out I couldn't use the officially proposed approach because it was crashing on HTC One (M8). I'm using a custom test runner instead.

Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work well, :shipit:

@LukasPaczos LukasPaczos merged commit a75a782 into master Apr 3, 2019
@LukasPaczos LukasPaczos deleted the lp-disable-leak-canary-instrumentation branch April 3, 2019 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

animators_cameraBearingCorrect flaky
2 participants