This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Disable leak canary during instrumentation tests #14296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
force-pushed
the
lp-disable-leak-canary-instrumentation
branch
from
4958768
to
f0f6919
Compare
LukasPaczos
force-pushed
the
lp-disable-leak-canary-instrumentation
branch
from
f0f6919
to
fd24f9b
Compare
|
Turns out I couldn't use the officially proposed approach because it was crashing on HTC One (M8). I'm using a custom test runner instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14237.
The common factor in the #14237 was leak canary freezing the app to collect the data, which caused the test to extend the "wait-for-idle" timeout and assert, even though the map was blank.
I wasn't able to reproduce the issue locally, so we can reopen #14237 if this PR doesn't fix it. In any case, we should disable leak canary during instrumentation tests anyway.