This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Fix build with mismatching glShaderSource signature #14339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpsantos
force-pushed
the
tmpsantos-android_compilation_fix
branch
from
cbb5e03 to
b6de626
Compare
tmpsantos
force-pushed
the
tmpsantos-android_compilation_fix
branch
from
b6de626 to
a2eff75
Compare
Not all GL implementations are following the glShaderSource signature specified by Khronos for GLES20. https://www.khronos.org/registry/OpenGL-Refpages/es2.0/xhtml/glShaderSource.xml
tmpsantos
force-pushed
the
tmpsantos-android_compilation_fix
branch
from
a2eff75 to
df335b9
Compare
tobrun
approved these changes
Apr 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all GL implementations are following the
glShaderSourcesignature specified by Khronos for GLES 2.0.https://www.khronos.org/registry/OpenGL-Refpages/es2.0/xhtml/glShaderSource.xml