Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Enable/Disable sku token handling #14467

Merged
merged 9 commits into from
Apr 24, 2019
Merged

[ios] Enable/Disable sku token handling #14467

merged 9 commits into from
Apr 24, 2019

Conversation

julianrex
Copy link
Contributor

@julianrex julianrex commented Apr 19, 2019 •
edited
Loading

Disables the default behavior of PR #14421 during the pre-release period to facilitate testing.

@julianrex julianrex added iOS Mapbox Maps SDK for iOS ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold beta blocker Blocks the next beta release labels Apr 19, 2019
@friedbunny
Copy link
Contributor

friedbunny commented Apr 19, 2019 •
edited
Loading

@julianrex like you mentioned in chat, I think a plist key would be a better way to handle this, since:

  • We want to ensure that the telemetry SKU token parameter is set for the initial turnstile, which will be easier to guarantee if we’re not worried about arbitrary settings of MGLAccountManager.accountsSDKEnabled.
  • We don’t need to support post-app-launch toggling of SKU token usage. (Right, @zugaldia?)

@zugaldia
Copy link
Member

We don’t need to support post-app-launch toggling of SKU token usage. (Right, @zugaldia?)

Correct - this is scoped to the pre-releases period only (effectively reverting this change before final release).

@julianrex
Copy link
Contributor Author

Should make the code simpler too.

@julianrex julianrex marked this pull request as ready for review April 19, 2019 20:45
@julianrex julianrex requested a review from 1ec5 as a code owner April 19, 2019 20:45
@julianrex julianrex requested a review from a team April 19, 2019 20:45
friedbunny
friedbunny reviewed Apr 19, 2019
View reviewed changes
platform/darwin/src/MGLAccountManager.m Outdated Show resolved Hide resolved
platform/darwin/src/http_file_source.mm Outdated Show resolved Hide resolved
@zugaldia zugaldia mentioned this pull request Apr 22, 2019
Merged
@julianrex julianrex requested a review from friedbunny April 23, 2019 18:58
@julianrex julianrex force-pushed the jrex/sku-token-patch branch from 0c28bb5 to 2cd9cae Compare April 24, 2019 15:21
@julianrex julianrex merged commit 43553c3 into master Apr 24, 2019
@julianrex julianrex deleted the jrex/sku-token-patch branch April 24, 2019 18:40
julianrex pushed a commit that referenced this pull request Apr 24, 2019
[ios] Enable/Disable sku token handling (#14467)
745c925
@julianrex julianrex mentioned this pull request Apr 24, 2019
Merged
julianrex pushed a commit that referenced this pull request Apr 24, 2019
[ios] CP #14467 - Enable/Disable sku token handling (#14502)
4920cec
@friedbunny friedbunny removed the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Apr 25, 2019
@friedbunny friedbunny added this to the release-mojito milestone Apr 25, 2019
@friedbunny friedbunny mentioned this pull request May 2, 2019
Merged
friedbunny added a commit that referenced this pull request May 14, 2019
@friedbunny
Revert "[ios] CP #14467 - Enable/Disable sku token handling (#14502)"
a0140f6 
This reverts commit 4920cec.
friedbunny added a commit that referenced this pull request May 15, 2019
@friedbunny
Revert "[ios] CP #14467 - Enable/Disable sku token handling (#14502)"
7f45afa 
This reverts commit 4920cec.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@friedbunny friedbunny friedbunny approved these changes

@zugaldia zugaldia Awaiting requested review from zugaldia

@1ec5 1ec5 Awaiting requested review from 1ec5

Assignees
No one assigned
Labels
beta blocker Blocks the next beta release iOS Mapbox Maps SDK for iOS
Projects
None yet
Milestone
release-mojito
Development

Successfully merging this pull request may close these issues.
3 participants
@julianrex @friedbunny @zugaldia