This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Make MGLLocationManager protocol swift friendly. #14477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabian-guerra
added
iOS
fabian-guerra
force-pushed
the
fabian-swift-14447
branch
from
22f26e1 to
ad0ac60
Compare
fabian-guerra
removed
the
needs changelog
|
Can we add some Swift tests for these? |
julianrex
approved these changes
Apr 24, 2019
fabian-guerra
added a commit
that referenced
this pull request
Apr 24, 2019
Improved MGLLocationManager protocol bridging to swift. * [ios] Make MGLLocationManager protocol swift friendly. * [ios] Update changelog.
fabian-guerra
added a commit
that referenced
this pull request
Apr 24, 2019
Improved MGLLocationManager protocol bridging to swift. * [ios] Make MGLLocationManager protocol swift friendly. * [ios] Update changelog.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14447
MGLLocationManagerprotocol is not swift friendly. Optional properties does not work well. This pr changes the properties for explicit setters/getters, although in ObjC there would be no difference; in swift it will require the direct invocation of each.