This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Check for valid superview to avoid crash on iOS 9 #14529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbunny
added
crash
needs changelog
friedbunny
approved these changes
Apr 29, 2019
julianrex
force-pushed
the
jrex/did-move-to-superview-constraints
branch
from
8fb4c2b to
e978408
Compare
julianrex
removed
the
needs changelog
julianrex
pushed a commit
that referenced
this pull request
Apr 30, 2019
julianrex
pushed a commit
that referenced
this pull request
Apr 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks for a valid superview before installing constraints. This avoids a crash on iOS 9.
The crash was reproduced with
ios-sdk-exampleson an iPad running iOS 9.3. (And this PR was tested on the same.)/cc @lloydsheng @chloekraw