This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Android GL Crash #1469
Merged
Android GL Crash #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (!painter) { | ||
| painter = util::make_unique<Painter>(*spriteAtlas, *glyphAtlas, *lineAtlas); |
There was a problem hiding this comment.
Indentation is broken here, no?
ljbade
force-pushed
the
1435-android-gl-crash
branch
7 times, most recently
from
8beeeae to
455b394
Compare
Initialise NativeMapView's EGL variables before Map Fix hang Add check for double pause Add test for double pause
ljbade
force-pushed
the
1435-android-gl-crash
branch
from
455b394 to
703e0bc
Compare
|
@jfirebaugh Can your review this and merge if happy once Travis passes (it should). |
|
Travis passed, ready for merging. |
|
This looks mostly on the Android c++ side of the house so it should be good to merge in. |
| _mbglMap = new mbgl::Map(*_mbglView, *_mbglFileSource, mbgl::MapMode::Continuous, _isTargetingInterfaceBuilder); | ||
| _mbglMap = new mbgl::Map(*_mbglView, *_mbglFileSource, mbgl::MapMode::Continuous); | ||
| if (_isTargetingInterfaceBuilder) { | ||
| _mbglMap->pause(); |
There was a problem hiding this comment.
Did you test this change in Interface Builder?
There was a problem hiding this comment.
OK, it does seem to work in Interface Builder designables, and MGLMapViews instantiated from storyboards seem to work fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking commits for updating the Android to Core GL integration for #1435