This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Fix: fill-extrusion-vertical-gradient was ignored. #14784 #14808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fill-extrusion-vertical-gradient "property-type": "data-constant" and it shouldn't be computed through property binders. Fixes: #14784
|
A minor tweak to rendering tests' tolerance, exposing the falsely passing test (making the previous state fail and this pass) is in mapbox/mapbox-gl-js#8309. |
alexshalamov
approved these changes
May 31, 2019
Following the style of the rest of the code. |
|
@astojilj thanks for fixing this! Looks like we can now enable some of the ignored render tests in |
chloekraw
added
the
needs changelog
friedbunny
removed
needs changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fill-extrusion-vertical-gradient is of "property-type": "data-constant" and it shouldn't be computed through property binders.
Compared to the state in #14784, render test now produces proper result.
Fixes: #14784