This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[core] Few performance fixes for RendererImpl #14930
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshalamov
force-pushed
the
alexshalamov_small_perf_fixes
branch
2 times, most recently
from
June 17, 2019 08:36
cab21a8
to
5d6b06a
Compare
alexshalamov
force-pushed
the
alexshalamov_small_perf_fixes
branch
from
June 17, 2019 10:40
cab21a8
to
5d6b06a
Compare
alexshalamov
changed the title
[WIP][core] Few performance fixes for RendererImpl
[core] Few performance fixes for RendererImpl
Jun 17, 2019
alexshalamov
requested review from
pozdnyakov,
tmpsantos,
astojilj and
kkaefer
and removed request for
pozdnyakov
June 17, 2019 15:13
friedbunny
added
Core
The cross-platform C++ core, aka mbgl
performance
Speed, stability, CPU usage, memory usage, or power usage
labels
Jun 21, 2019
friedbunny
added
the
needs changelog
Indicates PR needs a changelog entry prior to merging.
label
Jun 21, 2019
alexshalamov
force-pushed
the
alexshalamov_small_perf_fixes
branch
from
July 8, 2019 09:42
1cf350e
to
39e6f88
Compare
alexshalamov
requested review from
pozdnyakov
and removed request for
astojilj and
kkaefer
July 8, 2019 09:42
alexshalamov
removed
the
needs changelog
Indicates PR needs a changelog entry prior to merging.
label
Jul 8, 2019
/cc @tobrun for Android changelog https://github.com/mapbox/mapbox-gl-native/pull/14930/files#diff-303d773d7593cfbdd7331ce896ef36af |
Looks good, thank you for adding an entry! |
alexshalamov
force-pushed
the
alexshalamov_small_perf_fixes
branch
from
July 8, 2019 11:35
39e6f88
to
c5fbc09
Compare
alexshalamov
added a commit
that referenced
this pull request
Jul 8, 2019
alexshalamov
force-pushed
the
alexshalamov_small_perf_fixes
branch
from
July 8, 2019 13:35
c5fbc09
to
1a1b314
Compare
pozdnyakov
approved these changes
Jul 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
julianrex
approved these changes
Jul 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my limited C++ exp. Thanks for working on this!
- query rendered symbols only from layers that support it - remove unnecessary iterations over vectors
alexshalamov
force-pushed
the
alexshalamov_small_perf_fixes
branch
from
July 9, 2019 07:50
1a1b314
to
c147e72
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Core
The cross-platform C++ core, aka mbgl
performance
Speed, stability, CPU usage, memory usage, or power usage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds following changes: