Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Cache management API #14962

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Cache management API #14962

merged 1 commit into from
Jul 2, 2019

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jun 19, 2019

Follow up from #14925

Checklist:

  • integration
    • MVP
    • add javadoc
    • post callback to main thread
    • add instrumentation tests
    • check if filesource is not activated else call callback with error message
  • test app example

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jun 19, 2019
@tobrun tobrun added this to the release-p milestone Jun 19, 2019
@tobrun tobrun self-assigned this Jun 19, 2019
@jmkiley jmkiley mentioned this pull request Jun 20, 2019
5 tasks
@chloekraw
Copy link
Contributor

from #14978:

Revise existing documentation to clarify that MGLOfflineStorage manages both offline packs - and the ambient cache

does this need to be done on Android too? our offline/caching setup can be a bit confusing; I'd like to make sure it's clearly documented and communicated to customers

@tobrun
Copy link
Member Author

tobrun commented Jun 24, 2019

@chloekraw

Revise existing documentation to clarify that MGLOfflineStorage manages both offline packs - and the ambient cache

does this need to be done on Android too? our offline/caching setup can be a bit confusing; I'd like to make sure it's clearly documented and communicated to customers

I'm currently exposing this on the FileSource API and not the OfflineManger API on Android. (I don't believe that iOS supports the filesource concept). I could move it to the same component as iOS if we need to better align the APIs.

@tobrun
Copy link
Member Author

tobrun commented Jun 25, 2019

This PR also needs to add integration of invalidateOfflineRegion

@tobrun tobrun force-pushed the tvn-cache-management branch 2 times, most recently from c123708 to 5e03603 Compare June 27, 2019 15:20
@tobrun tobrun marked this pull request as ready for review June 27, 2019 15:22
@chloekraw chloekraw self-requested a review June 28, 2019 15:45
Copy link
Contributor

@chloekraw chloekraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks for the quick work on this, @tobrun + @langsmith! Let's hold on merging until the iOS side is ready and we can do a final compare + FAQ review.

@langsmith: could you add details of how customers should use each of the APIs implemented here (with code snippets) and when they should use them into the FAQ?

@julianrex
Copy link
Contributor

cc @jmkiley

@zugaldia
Copy link
Member

Capturing chat with @chloekraw, we're good to move forward with this PR as well as continuing the reference implementation work on the Demo App.

@chloekraw
Copy link
Contributor

Capturing chat with @chloekraw, we're good to move forward with this PR as well as continuing the reference implementation work on the Demo App.

yep! I just added two in-line documentation comments

@tobrun
Copy link
Member Author

tobrun commented Jul 2, 2019

yep! I just added two in-line documentation comments

comments addressed, thank you for 👀'ing !

@tobrun tobrun merged commit 21f7522 into master Jul 2, 2019
@tobrun tobrun deleted the tvn-cache-management branch July 2, 2019 12:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants