-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
from #14978:
does this need to be done on Android too? our offline/caching setup can be a bit confusing; I'd like to make sure it's clearly documented and communicated to customers |
I'm currently exposing this on the FileSource API and not the OfflineManger API on Android. (I don't believe that iOS supports the filesource concept). I could move it to the same component as iOS if we need to better align the APIs. |
This PR also needs to add integration of |
c123708
to
5e03603
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 thanks for the quick work on this, @tobrun + @langsmith! Let's hold on merging until the iOS side is ready and we can do a final compare + FAQ review.
@langsmith: could you add details of how customers should use each of the APIs implemented here (with code snippets) and when they should use them into the FAQ?
cc @jmkiley |
Capturing chat with @chloekraw, we're good to move forward with this PR as well as continuing the reference implementation work on the Demo App. |
...rm/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/offline/OfflineManager.java
Outdated
Show resolved
Hide resolved
...rm/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/offline/OfflineManager.java
Outdated
Show resolved
Hide resolved
...rm/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/offline/OfflineManager.java
Show resolved
Hide resolved
yep! I just added two in-line documentation comments |
comments addressed, thank you for 👀'ing ! |
5e03603
to
61b1768
Compare
Follow up from #14925
Checklist: