This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Decrease the minimum pixel distance required to interpolate during camera animation #15073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring camera animation The changes introduced in #9199 changed the minimum required pixel distance between start and end points to >= 1px in order to interpolate, which in scenarios of big zoom changes and low pixel density can result in animation to the previous position and then a jump to the target.
ansis
approved these changes
Jul 9, 2019
There was a problem hiding this comment.
@tobrun I don't think it's going to reintroduce #8300, this reverts only a part of changes from #9199.
Yep, I think the isfinite(...) might keep it from breaking but I'm not 100% sure. I originally added both approaches because I wasn't fully confident in either. Making this change should be ok but we need to keep an eye out for issues that might be caused by this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15072.
This PR reverts the required pixel distance to match what's been there before #9199, unless we'd like to split the target and zoom interpolation thresholds?