issue-link js-issue-link" data-error-text="Failed to load title" data-id="443902729" data-permission-text="Title is private" data-url="https://github.com/mapbox/mapbox-gl-native/issues/14664" data-hovercard-type="pull_request" data-hovercard-url="/mapbox/mapbox-gl-native/pull/14664/hovercard" href="https://github.com/mapbox/mapbox-gl-native/pull/14664">#14664. It was part of alternative approach that used enlarged viewport. Existing and added tests were not sufficient to spot the regression, since the collision check padding is usually larger than the center offset x and y. Annotation picking has tolerance of only 10 pixels but no annotation integration test was using content insets. Usage of offset is not needed because `posMatrix` in e.g. `CollisionIndex::projectPoint(const mat4& posMatrix, const Point<float>& point)` already incorporates center offset (projection matrix) and the code in current master was just offsetting all by the value. Modified [ios] MGLAnnotationViewIntegrationTests.testSelectingAnnotationWithCenterOffset to use different insets. It verifies the fix. Fixes [iOS] Annotations are not selectable (added via iosapp menu) #15106: In case of #15106, view's original content insets is {top:88, bottom:34}, causing that center offset is {x:0, y:27} and selection with tolerance of 10 wouldn't select annotation. After tapping the view, so that the header gets removed, view's content insets get changed to {top:44, bottom:34}, center offset is {x:0, y:5} and annotation selection would work, as described in #15106. Fixes: #15106

Commits

Commits on Jul 16, 2019

[core] Fix collision with content insets