Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Add compass button tap test #15186

Closed
wants to merge 2 commits into from

Conversation

friedbunny
Copy link
Contributor

Added a simple test that “tapping” the compass button will reset the map direction to north. Follow-up to #15055.

/cc @jmkiley

@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS tests labels Jul 19, 2019
@friedbunny friedbunny requested review from jmkiley and a team July 19, 2019 23:13
@friedbunny friedbunny self-assigned this Jul 19, 2019
@friedbunny friedbunny removed request for a team and jmkiley July 19, 2019 23:55
@friedbunny
Copy link
Contributor Author

Hrm, this is proving more difficult than I expected — regionDidChange: is firing, but just not when resetNorth is called...

@chloekraw chloekraw added this to the release-queso milestone Aug 1, 2019
@friedbunny friedbunny removed this from the release-ristretto milestone Aug 20, 2019
@friedbunny
Copy link
Contributor Author

While I do not have time to pursue this, I still believe it’s an area that we should invest more in testing.

@friedbunny friedbunny closed this Oct 15, 2019
@friedbunny friedbunny deleted the friedbunny-adds-compass-tap-test branch October 15, 2019 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants