Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Ensure default local ideographs font family is not overwrote #15253

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

LukasPaczos
Copy link
Member

Closes #14271 and unblocks #14269.

Turns out that because the TypedArray doesn't support default values for Objects, we were overwriting a default local ideographs font family with a null.

/cc @pozdnyakov @chloekraw

@LukasPaczos LukasPaczos added the Android Mapbox Maps SDK for Android label Jul 30, 2019
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great find

@LukasPaczos LukasPaczos merged commit f86f022 into master Jul 30, 2019
@LukasPaczos LukasPaczos deleted the lp-enable-local-ideographs branch July 30, 2019 11:53
@chloekraw
Copy link
Contributor

Awesome work @LukasPaczos !

@chloekraw
Copy link
Contributor

Is this worth adding a changelog entry? Seems like a pretty significant bugfix to me.

@chloekraw chloekraw added the needs changelog Indicates PR needs a changelog entry prior to merging. label Jul 30, 2019
@chloekraw chloekraw added this to the release-queso milestone Aug 1, 2019
@chloekraw chloekraw removed the needs changelog Indicates PR needs a changelog entry prior to merging. label Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offline tiles are not being rendered if they don't include CJK glyphs
3 participants