Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Fix issues for use-cases when icon-text-fit is combined with text-variable-anchor #15367

Merged
merged 3 commits into from
Aug 20, 2019

Conversation

alexshalamov
Copy link
Contributor

There are multiple issues related to icon-text-fit when it is used in combination with text-variable-anchor and text-writing-mode

  • Collision feature box for an icon has wrong size
  • Collision feature should be shifted together with text box
  • Collision debug box for an icon should be shifted together with text
  • Vertically oriented text box might be of different size, thus vertical icon might be needed

Fixes: #15346
Adresses: mapbox/mapbox-gl-js#8583

Copy link
Contributor

@ansis ansis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great!

@chloekraw
Copy link
Contributor

chloekraw commented Aug 20, 2019

Possible changelog entry:

Fixed rendering and collision detection issues with using text-variable-anchor and icon-text-fit properties on the same layer.

(Noooo sorry I closed the pr by mistake.)

@chloekraw chloekraw closed this Aug 20, 2019
@chloekraw chloekraw reopened this Aug 20, 2019
@alexshalamov alexshalamov requested a review from a team August 20, 2019 08:17
@alexshalamov alexshalamov removed the needs changelog Indicates PR needs a changelog entry prior to merging. label Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] Combination of text-variable-anchor and icon-text-fit is broken
4 participants