This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] fix compass font thinner than previous version on iOS 13 #15547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedbunny
added
the
needs changelog
friedbunny
reviewed
Sep 3, 2019
There was a problem hiding this comment.
A few requests:
- Please post a screenshot comparing iOS 12, iOS 13 before, and iOS 13 after.
- Suggested changelog entry:
* Fixed an issue with the appearance of the compass text in iOS 13. ([#15547](https://github.com/mapbox/mapbox-gl-native/pull/15547)) - I also
suggestedmerged a few fixes for formatting nits.
Other comments:
- We should file a radar for this, but I don’t think we can expect it to be fixed soon (if ever). If we file a radar now, we should add an inline comment in this PR.
- This would be a good candidate for image comparison tests (which we do not have yet), given that it’s an isolated view that can be rendered accurately offline.
|
Update for screenshots: Before this PR on iOS13: After this PR on iOS13: |
m-stephen
removed
the
needs changelog
friedbunny
approved these changes
Sep 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #14831
It seems that
UIFontWeightLighton iOS13 is as thin asUIFontWeightUltraLighton iOS12.This is a solution for fixing this issue.
We can wait to merge this PR until iOS13 released and let's see Apple could fix this issue or not.