This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Coalesce requests for the same missing image #15778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
added
bug
performance
pozdnyakov
force-pushed
the
mikhail_coalesce_pending_image_requests
branch
from
0e3e306
to
50d16c0
Compare
pozdnyakov
added
the
needs changelog
pozdnyakov
force-pushed
the
mikhail_coalesce_pending_image_requests
branch
3 times, most recently
from
2e1882a
to
b5c04b8
Compare
alexshalamov
reviewed
Oct 9, 2019
ansis
reviewed
Oct 9, 2019
This commit coalesces the repeated `onStyleImageMissing` calls for the same image. It also simplifies the image manager code.
pozdnyakov
force-pushed
the
mikhail_coalesce_pending_image_requests
branch
from
9ed48f2
to
a6c923d
Compare
pozdnyakov
removed
the
needs changelog
alexshalamov
approved these changes
Oct 10, 2019
Unlike icons, pattern changes are not caught with style-diff meaning that the existing request could be from the previous style and we cannot coalesce requests for them.
… test So that it checks missing images requests coalescing.
pozdnyakov
force-pushed
the
mikhail_coalesce_pending_image_requests
branch
from
a6c923d
to
17bcdb1
Compare
|
There is a weird binary size degradation on Android arm-v8 - |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit coalesces the repeated
onStyleImageMissingcallsfor the same image.
It also simplifies the image manager code.
Fixes #15497