Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Coalesce requests for the same missing image #15778

Merged
merged 6 commits into from
Oct 10, 2019

Conversation

pozdnyakov
Copy link
Contributor

This commit coalesces the repeated onStyleImageMissing calls
for the same image.

It also simplifies the image manager code.

Fixes #15497

@pozdnyakov pozdnyakov added bug performance Speed, stability, CPU usage, memory usage, or power usage Core The cross-platform C++ core, aka mbgl labels Oct 8, 2019
@pozdnyakov pozdnyakov self-assigned this Oct 8, 2019
@pozdnyakov pozdnyakov force-pushed the mikhail_coalesce_pending_image_requests branch from 0e3e306 to 50d16c0 Compare October 8, 2019 14:41
@pozdnyakov pozdnyakov added the needs changelog Indicates PR needs a changelog entry prior to merging. label Oct 8, 2019
@pozdnyakov pozdnyakov force-pushed the mikhail_coalesce_pending_image_requests branch 3 times, most recently from 2e1882a to b5c04b8 Compare October 8, 2019 20:13
@pozdnyakov pozdnyakov marked this pull request as ready for review October 9, 2019 09:13
Copy link
Contributor

@ansis ansis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it makes sense but I'm also not familiar enough with the scheduler to know if this is safe. I'll leave the full review to alex because of tha

This commit coalesces the repeated `onStyleImageMissing` calls
for the same image.

It also simplifies the image manager code.
@pozdnyakov pozdnyakov force-pushed the mikhail_coalesce_pending_image_requests branch from 9ed48f2 to a6c923d Compare October 10, 2019 08:53
@pozdnyakov pozdnyakov requested a review from a team October 10, 2019 08:53
@pozdnyakov pozdnyakov removed the needs changelog Indicates PR needs a changelog entry prior to merging. label Oct 10, 2019
Unlike icons, pattern changes are not caught with
style-diff meaning that the existing request could
be from the previous style and we cannot coalesce
requests for them.
… test

So that it checks missing images requests coalescing.
@pozdnyakov pozdnyakov force-pushed the mikhail_coalesce_pending_image_requests branch from a6c923d to 17bcdb1 Compare October 10, 2019 11:29
@pozdnyakov
Copy link
Contributor Author

There is a weird binary size degradation on Android arm-v8 - [Unmapped] binary section is bloated. This must be related to the first usage of Scheduler::makeWeakPtr() - this is to be addressed in a follow up patch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Core The cross-platform C++ core, aka mbgl performance Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image missing callback impacts rendering of other layers
3 participants