This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Fix supercluster lambdas capturing #15989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
added
bug
Core
pozdnyakov
force-pushed
the
mikhail_fix_supercluster
branch
2 times, most recently
from
09dd3e2
to
1c7c4b2
Compare
- share the `GeoJSONOptions` instances using `Immutable<GeoJSONOptions>` - avoid extra copying - fix wrapping of the `GeoJSONOptions` instances in supercluster map/reduce lambdas. Previously, local variables were wrapped by reference.
pozdnyakov
force-pushed
the
mikhail_fix_supercluster
branch
from
1c7c4b2
to
86c7263
Compare
alexshalamov
approved these changes
Nov 28, 2019
tmpsantos
approved these changes
Nov 28, 2019
springmeyer
pushed a commit
to mapbox/mapbox-gl-native-ios
that referenced
this pull request
Dec 13, 2019
captainbarbosa
pushed a commit
to mapbox/mapbox-gl-native-ios
that referenced
this pull request
Dec 13, 2019
fabian-guerra
pushed a commit
to mapbox/mapbox-gl-native-ios
that referenced
this pull request
Dec 13, 2019
fabian-guerra
added a commit
to mapbox/mapbox-gl-native-ios
that referenced
this pull request
Dec 14, 2019
…table GeoJSON sources (V2) (#103) * Podspec updates for 5.6.0-beta.1 * Bump gl-native submodule to release-tequila * adapt to mapbox/mapbox-gl-native#15989 (#102) * More changelog/install updates * Fix telem dependency docs * More clarifying documentation * Fix typo
captainbarbosa
pushed a commit
to mapbox/mapbox-gl-native-ios
that referenced
this pull request
Dec 14, 2019
…table GeoJSON sources (V2) (#103) * Podspec updates for 5.6.0-beta.1 * Bump gl-native submodule to release-tequila * adapt to mapbox/mapbox-gl-native#15989 (#102) * More changelog/install updates * Fix telem dependency docs * More clarifying documentation * Fix typo
captainbarbosa
added a commit
to mapbox/mapbox-gl-native-ios
that referenced
this pull request
Dec 14, 2019
…table GeoJSON sources (V2) (#103) (#104) * Podspec updates for 5.6.0-beta.1 * Bump gl-native submodule to release-tequila * adapt to mapbox/mapbox-gl-native#15989 (#102) * More changelog/install updates * Fix telem dependency docs * More clarifying documentation * Fix typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GeoJSONOptionsinstances usingImmutable<GeoJSONOptions>- avoid extra copying