Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

fix really overscaled lines #16045

Merged
merged 3 commits into from
Dec 17, 2019
Merged

Conversation

ansis
Copy link
Contributor

@ansis ansis commented Dec 11, 2019

fix #16018

We resample lines after sharp corners in some situations. When tiles were really overscaled, sometimes we didn't have enough precision to represent the resampled vertex because it was too close. Disabling this after a certain point prevents this.

It looks like some kind of tests for vertex buffer size are failing. Where are these set and how can they be updated?
https://385308-16286131-gh.circle-artifacts.com/0/tests/render-test-app/render-tests_android-manifest-probe-network-gfx_index.html
https://385305-16286131-gh.circle-artifacts.com/0/tests/metrics/render-tests_next-linux-gcc8-release-probe-gfx-network_index.html

@ansis ansis requested a review from pozdnyakov December 11, 2019 21:07
@alexshalamov alexshalamov force-pushed the ansis-fix-really-overscaled-lines branch from 71396af to c428b09 Compare December 17, 2019 11:52
@alexshalamov alexshalamov added the needs changelog Indicates PR needs a changelog entry prior to merging. label Dec 17, 2019
@alexshalamov alexshalamov force-pushed the ansis-fix-really-overscaled-lines branch from c428b09 to 80588da Compare December 17, 2019 12:31
@alexshalamov alexshalamov removed the needs changelog Indicates PR needs a changelog entry prior to merging. label Dec 17, 2019
@alexshalamov
Copy link
Contributor

@ansis @pozdnyakov I rebased this PR to master, added baselines and a changelog. Feel free to merge if all bots are green.

@pozdnyakov pozdnyakov merged commit 9d75856 into master Dec 17, 2019
@pozdnyakov pozdnyakov deleted the ansis-fix-really-overscaled-lines branch December 17, 2019 13:46
@chloekraw chloekraw added this to the release-unicorn milestone Dec 18, 2019
@ansis
Copy link
Contributor Author

ansis commented Jan 14, 2020

Thanks for merging!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port overscaled line rendering fix from -js
4 participants