This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Update toGeoJSON in android_conversion.hpp #16243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
reviewed
Feb 28, 2020
We don't have test for this part yet. Now test it with demo app in android repo mapbox/mapbox-gl-native-android#198 |
Chaoba
force-pushed
the
kl-within-geojson
branch
from
de68ace to
006c915
Compare
alexshalamov
approved these changes
Mar 3, 2020
pozdnyakov
reviewed
Mar 3, 2020
Chaoba
force-pushed
the
kl-within-geojson
branch
from
006c915 to
b9a7ffb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
withinexpression need its parameter be an Object(map in android) and then convert it to a Geojon object.toGeoJSONmethod inandroid_conversion.hppcan't handle Object before and it seems not easy to convert an Object to string and then convert the string to GeoJSON object. So I put the whole json body of Polygon into the Object with keyjson. Maybe this's not a good idea, it will be nice if a better solution could be brought up。Related pr in android sdk: mapbox/mapbox-gl-native-android#198