This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[core][tile mode] Introduce API to collect placed symbols data #16339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
force-pushed
the
mikhail_get_placed_symbols_data_api
branch
2 times, most recently
from
March 26, 2020 11:51
d838256
to
c0dc47c
Compare
pozdnyakov
changed the title
[core] Introduce API to collect placed symbols data
[core][tile mode] Introduce API to collect placed symbols data
Mar 26, 2020
pozdnyakov
force-pushed
the
mikhail_get_placed_symbols_data_api
branch
from
March 26, 2020 15:24
9971b37
to
fe68347
Compare
tmpsantos
approved these changes
Mar 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few comments
pozdnyakov
force-pushed
the
mikhail_get_placed_symbols_data_api
branch
2 times, most recently
from
March 30, 2020 21:33
03631d0
to
7110ed4
Compare
alexshalamov
approved these changes
Mar 31, 2020
The following methods are added to the `Renderer` class: - `collectPlacedSymbolData()` enables or disables collecting of the placed symbols data - `getPlacedSymbolsData()` if collecting of the placed symbols data is enabled, returns the reference to the `PlacedSymbolData` vector holding the collected data.
pozdnyakov
force-pushed
the
mikhail_get_placed_symbols_data_api
branch
from
April 1, 2020 21:46
7110ed4
to
41429d8
Compare
pozdnyakov
added this to the
OP1-20: Full testing rendering maps using "tile mode" milestone
May 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following methods are added to the
Renderer
class in implemented in the Tile map mode:collectPlacedSymbolData()
enables or disables collecting of the placed symbols data
getPlacedSymbolsData()
if collecting of the placed symbols data is enabled, returns the
reference to the
PlacedSymbolData
vector holding the collected data.Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/232