Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core][tile mode] Introduce API to collect placed symbols data #16339

Merged
merged 5 commits into from
Apr 2, 2020

Conversation

pozdnyakov
Copy link
Contributor

@pozdnyakov pozdnyakov commented Mar 25, 2020

The following methods are added to the Renderer class in implemented in the Tile map mode:

  • collectPlacedSymbolData()
    enables or disables collecting of the placed symbols data

  • getPlacedSymbolsData()
    if collecting of the placed symbols data is enabled, returns the
    reference to the PlacedSymbolData vector holding the collected data.

Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/232

@pozdnyakov pozdnyakov self-assigned this Mar 25, 2020
@pozdnyakov pozdnyakov force-pushed the mikhail_get_placed_symbols_data_api branch 2 times, most recently from d838256 to c0dc47c Compare March 26, 2020 11:51
@pozdnyakov pozdnyakov marked this pull request as ready for review March 26, 2020 15:17
@pozdnyakov pozdnyakov requested a review from alexshalamov March 26, 2020 15:17
@pozdnyakov pozdnyakov changed the title [core] Introduce API to collect placed symbols data [core][tile mode] Introduce API to collect placed symbols data Mar 26, 2020
@pozdnyakov pozdnyakov force-pushed the mikhail_get_placed_symbols_data_api branch from 9971b37 to fe68347 Compare March 26, 2020 15:24
@pozdnyakov pozdnyakov requested a review from tmpsantos March 26, 2020 17:28
Copy link
Contributor

@tmpsantos tmpsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few comments

test/map/map.test.cpp Outdated Show resolved Hide resolved
src/mbgl/text/placement.cpp Show resolved Hide resolved
@pozdnyakov pozdnyakov requested a review from riastrad March 26, 2020 18:13
include/mbgl/renderer/renderer.hpp Show resolved Hide resolved
include/mbgl/renderer/renderer.hpp Outdated Show resolved Hide resolved
src/mbgl/text/placement.cpp Show resolved Hide resolved
@pozdnyakov pozdnyakov force-pushed the mikhail_get_placed_symbols_data_api branch 2 times, most recently from 03631d0 to 7110ed4 Compare March 30, 2020 21:33
The following methods are added to the `Renderer` class:
- `collectPlacedSymbolData()`
  enables or disables collecting of the placed symbols data

- `getPlacedSymbolsData()`
  if collecting of the placed symbols data is enabled, returns the
  reference to the `PlacedSymbolData` vector holding the collected data.
@pozdnyakov pozdnyakov force-pushed the mikhail_get_placed_symbols_data_api branch from 7110ed4 to 41429d8 Compare April 1, 2020 21:46
@pozdnyakov pozdnyakov merged commit 7d26a16 into master Apr 2, 2020
@pozdnyakov pozdnyakov deleted the mikhail_get_placed_symbols_data_api branch April 2, 2020 08:50
@pozdnyakov pozdnyakov added this to the OP1-20: Full testing rendering maps using "tile mode" milestone May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants