Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add generic setter for Layer's 'source' property #16406

Merged
merged 2 commits into from
Apr 16, 2020

Conversation

alexshalamov
Copy link
Contributor

  • Add setter for 'source' property
  • Test generic setters via setProperty method

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • apply needs changelog label if a changelog is needed (remove label when added)

@alexshalamov alexshalamov changed the title Add generic setter for 'source' property Add generic setter for Layer's 'source' property Apr 16, 2020
@alexshalamov alexshalamov marked this pull request as ready for review April 16, 2020 14:03
@alexshalamov alexshalamov requested a review from pozdnyakov April 16, 2020 14:03
Copy link
Contributor

@pozdnyakov pozdnyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexshalamov alexshalamov force-pushed the alexshalamov_fix_setProperty_for_source branch from 91b8250 to a38679b Compare April 16, 2020 14:27
- Add setter for 'source' property
- Test generic setters via setProperty method
@alexshalamov alexshalamov force-pushed the alexshalamov_fix_setProperty_for_source branch from a38679b to 1bc34f0 Compare April 16, 2020 16:33
@alexshalamov alexshalamov merged commit a71e672 into master Apr 16, 2020
@alexshalamov alexshalamov deleted the alexshalamov_fix_setProperty_for_source branch April 16, 2020 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants