This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked from af04848.
Not sure what’s up with the Android and Linux build bots, but this change has nothing to do with those platforms. |
fabian-guerra
approved these changes
Apr 25, 2020
ios-unit-test-runner fails with: <failure message="/Users/distiller/project/test/storage/online_file_source.test.cpp:388 Expected: (util::now()) < (res.error->retryAfter), actual: 8-byte object <71-A6 A3-5E 00-00 00-00> vs 16-byte object <01-79 4C-6F 61-64 73-00 71-A6 A3-5E 00-00 00-00>" type="">
/Users/distiller/project/test/storage/online_file_source.test.cpp:388 Expected: (util::now()) < (res.error->retryAfter), actual: 8-byte object <71-A6 A3-5E 00-00 00-00> vs 16-byte object <01-79 4C-6F 61-64 73-00 71-A6 A3-5E 00-00 00-00>
</failure> Linux builds are failing with:
The android-api-breakage build has been failing since v1.5.1: android-api-breakage
None of these builds are related to the changes in this PR. /cc @mapbox/gl-native |
captainbarbosa
approved these changes
Apr 25, 2020
Not supported at the moment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked #16412, #16421 and updated the changelog for v1.5.2.
/cc @chloekraw @captainbarbosa