This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Support polygon geometry type in distance
expression
#16446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmiao
added
the
needs changelog
Indicates PR needs a changelog entry prior to merging.
label
Apr 29, 2020
zmiao
force-pushed
the
zmiao-distance-polygon-support
branch
2 times, most recently
from
April 29, 2020 09:17
06aad3d
to
6fd42f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nits
zmiao
force-pushed
the
zmiao-distance-polygon-support
branch
from
April 29, 2020 09:43
6fd42f5
to
55395aa
Compare
pozdnyakov
reviewed
Apr 29, 2020
zmiao
force-pushed
the
zmiao-distance-polygon-support
branch
3 times, most recently
from
April 29, 2020 14:48
f9b79e1
to
5824be2
Compare
pozdnyakov
approved these changes
Apr 29, 2020
zmiao
force-pushed
the
zmiao-distance-polygon-support
branch
from
April 29, 2020 15:25
5824be2
to
fa6edb7
Compare
alexshalamov
approved these changes
Apr 29, 2020
zmiao
force-pushed
the
zmiao-distance-polygon-support
branch
from
April 29, 2020 19:52
7b0e926
to
a78984f
Compare
alexshalamov
removed
the
needs changelog
Indicates PR needs a changelog entry prior to merging.
label
Apr 29, 2020
fsrrt
reviewed
Oct 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr will add support for
Polygon
geometry type evaluation indistance
expression.render tests: mapbox/mapbox-gl-js#9602
Launch Checklist
@mapbox/maps-android @mapbox/maps-ios @mapbox/core-sdk
if this PR adds or updates a public API@mapbox/gl-js
if this PR includes shader changes or needs a js portneeds changelog
label if a changelog is needed (remove label when added)