Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Support polygon geometry type in distance expression #16446

Merged
merged 5 commits into from
Apr 29, 2020

Conversation

zmiao
Copy link
Contributor

@zmiao zmiao commented Apr 29, 2020

This pr will add support for Polygon geometry type evaluation in distance expression.

render tests: mapbox/mapbox-gl-js#9602

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • tagged @mapbox/maps-android @mapbox/maps-ios @mapbox/core-sdk if this PR adds or updates a public API
  • tagged @mapbox/gl-js if this PR includes shader changes or needs a js port
  • apply needs changelog label if a changelog is needed (remove label when added)

@zmiao zmiao requested a review from a team as a code owner April 29, 2020 07:13
@zmiao zmiao self-assigned this Apr 29, 2020
@zmiao zmiao added the needs changelog Indicates PR needs a changelog entry prior to merging. label Apr 29, 2020
@zmiao zmiao force-pushed the zmiao-distance-polygon-support branch 2 times, most recently from 06aad3d to 6fd42f5 Compare April 29, 2020 09:17
Copy link
Contributor

@alexshalamov alexshalamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits

src/mbgl/style/expression/distance.cpp Outdated Show resolved Hide resolved
src/mbgl/style/expression/distance.cpp Show resolved Hide resolved
src/mbgl/style/expression/distance.cpp Show resolved Hide resolved
src/mbgl/style/expression/distance.cpp Show resolved Hide resolved
@zmiao zmiao force-pushed the zmiao-distance-polygon-support branch from 6fd42f5 to 55395aa Compare April 29, 2020 09:43
@zmiao zmiao force-pushed the zmiao-distance-polygon-support branch 3 times, most recently from f9b79e1 to 5824be2 Compare April 29, 2020 14:48
@zmiao zmiao force-pushed the zmiao-distance-polygon-support branch from 5824be2 to fa6edb7 Compare April 29, 2020 15:25
@zmiao zmiao force-pushed the zmiao-distance-polygon-support branch from 7b0e926 to a78984f Compare April 29, 2020 19:52
@alexshalamov alexshalamov removed the needs changelog Indicates PR needs a changelog entry prior to merging. label Apr 29, 2020
@zmiao zmiao merged commit 296ca0d into master Apr 29, 2020
@zmiao zmiao deleted the zmiao-distance-polygon-support branch April 29, 2020 23:31
Copy link

@fsrrt fsrrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants